Skip to content

feat!(generator): type and id are allowed as attribute names and will not be converted #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2021

Conversation

dbanty
Copy link
Collaborator

@dbanty dbanty commented May 2, 2021

Closes #378 which was reported by @forest-benchling

@dbanty dbanty requested a review from emann May 2, 2021 16:55
@dbanty dbanty added this to the 0.9.0 milestone May 2, 2021
@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #407 (56d645d) into main (5805c03) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #407   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           46        46           
  Lines         1531      1531           
=========================================
  Hits          1531      1531           
Impacted Files Coverage Δ
openapi_python_client/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5805c03...56d645d. Read the comment docs.

@forest-benchling
Copy link
Collaborator

Wooooo! 🎉 thanks @dbanty, <- @dtkav @bowenwr @packyg

@dbanty dbanty merged commit 890411a into main May 3, 2021
@dbanty dbanty deleted the allow-type-and-id-as-attributes branch May 3, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow id and type as model attributes
3 participants